Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grpc stream cancelled due to in-activity log message #1378

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Update grpc stream cancelled due to in-activity log message #1378

merged 2 commits into from
Feb 7, 2023

Conversation

jaffinito
Copy link
Member

Description

  • Updates the ResponseStreamWrapper exception message to detect when a stream is automatically cancelled due to inactivity and use a more descriptive lg message. The updated log message explains that this happened and that a new stream will be created when one is needed.
  • Adds the consumer ID to the log messages in more places
  • Updates the usage of "gRPC" to match the format.

Author Checklist

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)
  • Review Changelog

@jaffinito jaffinito marked this pull request as ready for review February 6, 2023 22:06
@jaffinito jaffinito requested a review from a team February 6, 2023 22:06
chynesNR
chynesNR previously approved these changes Feb 6, 2023
View reviewed changes
JcolemanNR
JcolemanNR previously approved these changes Feb 6, 2023
View reviewed changes
@jaffinito jaffinito dismissed stale reviews from JcolemanNR and chynesNR via 30b2b91 February 6, 2023 23:33
@jaffinito jaffinito merged commit b9902c9 into feature/grpc-hybrid-solution Feb 7, 2023
@jaffinito jaffinito deleted the grpc-improve-cancel-message2 branch February 7, 2023 19:31
chynesNR added a commit that referenced this pull request Feb 14, 2023
@JcolemanNR @chynesNR
@tippmar-nr @jaffinito @nrcventura
grpc-dotnet migration for .NET Core (#1367)
5b6f46a 
* Remove grpc-dotnet binaries from Linux build
* Remove gRPC binaries from core agent, upgrade gRPC packages (#1368)
* Remove Grpc native dlls from .NET Core agent (on windows)
* ILRepack Microsoft.Extensions.Logging.Abstractions for grpc-dotnet (#1375)
* Update grpc stream cancelled due to in-activity log message (#1378)
* Update changelog
* Add missing error metrics and stabilize Infinite Tracing integration tests  (#1379)
* Enable grpc compression for infinite tracing (#1383)
* Add Infinite Tracing compression supportability metric (#1385)
* Add warning when grpc_proxy is detected (#1387)
* Delay retries when 'internal' gRPC errors are encountered (#1388)

---------

Co-authored-by: chynesNR <chynes@newrelic.com>
Co-authored-by: Marty Tippin <120425148+tippmar-nr@users.noreply.github.com>
Co-authored-by: Jacob Affinito <jaffinito@newrelic.com>
Co-authored-by: Chris Ventura <45495992+nrcventura@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcolemanNR JcolemanNR JcolemanNR approved these changes

@tippmar-nr tippmar-nr tippmar-nr approved these changes

@chynesNR chynesNR chynesNR left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaffinito @JcolemanNR @chynesNR @tippmar-nr