Attribute limit fix #1335
Merged
Attribute limit fix #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibutes, as attributes with different applicability can have the same name.
…it, with unit test coverage
JcolemanNR
requested review from
jaffinito,
tippmar-nr,
chynesNR and
nr-ahemsath
tippmar-nr
reviewed
Jan 12, 2023
chynesNR
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the AttributeValueCollections to more reliably track attribute counts, and allows attributes in the collection to be updated even if the collection has hit its capacity.
Author Checklist
Reviewer Checklist