Stop any harvests while reconnecting #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JcolemanNR
reviewed
Sep 27, 2022
src/Agent/NewRelic/Agent/Core/Aggregators/LogEventAggregator.cs
Outdated
Show resolved
Hide resolved
JcolemanNR
reviewed
Sep 27, 2022
src/Agent/NewRelic/Agent/Core/Aggregators/AbstractAggregator.cs
Outdated
Show resolved
Hide resolved
vuqtran88
changed the title
chynesNR
reviewed
Sep 28, 2022
JcolemanNR
approved these changes
Sep 29, 2022
chynesNR
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an edge case where a user sets to disable event collection for specific event types from the New Relic APM UI and the agent is issued a reconnect, the agent still sends up the disabled events during the agent reconnecting period.
During the agent reconnecting window, all of the configuration settings get reset to the default values while waiting for the configuration setting backend negotiation to complete. This causes some events still being collected and sent up during this time period regardless some events collection were explicitly disabled.
This PR proposes a fix where the agent stops any scheduled
Harvestduring the agent's reconnecting process.