Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variables for SendDataOnExit functionality #1250

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

JcolemanNR
Copy link
Contributor

@JcolemanNR JcolemanNR commented Sep 23, 2022

Description

This PR adds new environment variables to control SendDataOnExit functionality:

  • NEW_RELIC_SEND_DATA_ON_EXIT: (boolean) enables/disables send data on exit
  • NEW_RELIC_SEND_DATA_ON_EXIT_THRESHOLD_MS: (uint) sets the minimum number of MS that the application must have been running before data will be sent on exit (when enabled).

Includes unit tests.

Author Checklist

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)
  • Review Changelog

Copy link
Member

@nr-ahemsath nr-ahemsath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Glad to see we're increasing customers' ability to configure the agent by using environment variables, as this is often the most convenient way in cloud-hosted and/or containerized scenarios.

@JcolemanNR JcolemanNR merged commit 02da8f6 into main Sep 26, 2022
@JcolemanNR JcolemanNR deleted the jc/add-send-data-on-exit-env-vars branch September 26, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants