Add missing Microsoft.Data.SqlClient instrumentation for .NET Framework #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for .NET Framework AsyncParameterizedQuery tests
… remaining test fixtures, fix formatting in all MSSQL tests
chynesNR
reviewed
Sep 22, 2022
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/Sql/Instrumentation.xml
Outdated
Show resolved
Hide resolved
chynesNR
previously approved these changes
Sep 22, 2022
chynesNR
previously approved these changes
Sep 22, 2022
chynesNR
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our existing Microsoft.Data.SqlClient instrumentation only had test coverage for .NET Core. This allowed a bug to slip under the radar where not all forms of
ExecuteReaderandExecuteReaderAsyncwere properly profiled in .NET Framework. The existing instrumentation points worked fine for .NET Core, but the Microsoft Implementation for .NET Framework and .NET Core differ. A new internal form ofExecuteReaderAsync, and a new form ofExecuteReaderare now included in the instrumentation XML for Microsoft.Data.SqlClient. The newly added integration tests will break if the new instrumentation entries are removed, so there is high confidence that this resolves the issues with missing instrumentation reported by customers.Closes #620.
Author Checklist
Reviewer Checklist