Setting from NR backend should override setting from MAX_EVENT_SAMPLES_STORED and MAX_TRANSACTION_SAMPLES_STORED env var #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuqtran88
changed the title
nr-ahemsath
requested changes
Sep 9, 2022
…on.cs Co-authored-by: Alex Hemsath <57361211+nr-ahemsath@users.noreply.github.com>
…on.cs Co-authored-by: Alex Hemsath <57361211+nr-ahemsath@users.noreply.github.com>
nr-ahemsath
approved these changes
Sep 9, 2022
nr-ahemsath
requested changes
Sep 9, 2022
There was a problem hiding this comment.
@vuqtran88 Josh reminded me that we need a changelog entry for this
nr-ahemsath
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the current state, when MAX_EVENT_SAMPLES_STORED env var is set, the agent uses value from the env var for the preconnect request. The server replies with a smaller value (whatver the value sent up get divided by 12). However, the agent won't use the value from the server because our current logic allows the env to override any config values. This causes configuration mismatched as well as incorrect
...\EvenHarvest\CustomEventData\HarvestLimitsupportability metric value being reported.The same story happens to the MAX_TRANSACTION_SAMPLES_STORED env var usage.
The right approach is to let the server config to dictate the final value that the agent will use.