Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logging attributes to match spec #1144

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Update logging attributes to match spec #1144

merged 2 commits into from
Jun 10, 2022

Conversation

jaffinito
Copy link
Member

@jaffinito jaffinito commented Jun 9, 2022 •
edited by JcolemanNR
Loading

Description

  • Use level instead of log.level
  • Move span and trace id to root of log event instead of under attributes
  • Update the various identifiers in code to use a variation of "Level" instead of "LogLevel" to keep naming consistent
  • Updated unit and integration tests to account for changes

All unit and integration tests pass locally.

Author Checklist

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)
  • Review Changelog

@jaffinito jaffinito added the chore Something the New Relic engineering team needs to keep track of doing label Jun 9, 2022
@jaffinito jaffinito added this to the Logging Initiative - NLog milestone Jun 9, 2022
@jaffinito jaffinito requested review from vuqtran88 and JcolemanNR June 9, 2022 23:53
JcolemanNR
JcolemanNR approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@JcolemanNR JcolemanNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This is good to merge after CI passes

@jaffinito
Copy link
Member Author

Got some failed to publish errors, re-running failed jobs.

@jaffinito jaffinito merged commit bdc602c into main Jun 10, 2022
@jaffinito jaffinito deleted the logging-fix-attributes branch June 10, 2022 16:40
This was linked to issues Jun 10, 2022
For logging, change log.level back to level #1105
Closed
For logging, move the trace.id and span.id from LogEvent.Attributes to root of event. #1106
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcolemanNR JcolemanNR JcolemanNR approved these changes

@vuqtran88 vuqtran88 Awaiting requested review from vuqtran88

Assignees
No one assigned
Labels
chore Something the New Relic engineering team needs to keep track of doing
Projects
None yet
Milestone
Major Release 10.0
3 participants
@jaffinito @JcolemanNR @angelatan2