Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code Level Metrics for CodeStream integration #1135

Merged
merged 14 commits into from
Jun 8, 2022

Conversation

JcolemanNR
Copy link
Contributor

@JcolemanNR JcolemanNR commented Jun 7, 2022

Description

Add the ability for the agent to sent Code Level Metrics to support the CodeStream integration. This is disabled by default, and must be enabled via newrelic.config or environment variable. When enabled code.function and code.namespace attributes are added to spans which enables the CodeStream IDE Plugin to display method execution information in code.

Author Checklist

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)
  • Review Changelog

michaelgoin and others added 11 commits May 18, 2022 09:59
* Adds namespace and function attributes to spans.

Defaults usage to instrumented method TypeName and MethodName.

* Adds code level metrics enabled configuration defaulting to false.
* Adds user/customer code level span attributes for Web API 2.

* Adds Owin hosted Web API 2 tests for CLM.
* Add CLM for .NET MVC (Framework). Minor refactoring for performance. Commentary on possible work

* Finalize impl

* Integration tests

* CR Feedback. Update integration test workflow to run Code Level Metrics tests
…rack down issues. (#1124)

Adds waiting for span event log line. Prevents inlining for custom methods in AgentApiExecutor. Asserts individual span events where found.
@JcolemanNR JcolemanNR added the feature request To tag an issue after triage that is a feature instead of TD label Jun 7, 2022
@JcolemanNR JcolemanNR added this to the Code Level Metrics milestone Jun 7, 2022
Copy link
Member

@nr-ahemsath nr-ahemsath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR with @JcolemanNR and @michaelgoin. Found a few minor things to correct. Looks good to us. 👍

@JcolemanNR JcolemanNR merged commit e925389 into main Jun 8, 2022
@JcolemanNR JcolemanNR deleted the code-level-metrics-feature-branch branch June 8, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request To tag an issue after triage that is a feature instead of TD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants