-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Code Level Metrics for CodeStream integration #1135
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds namespace and function attributes to spans. Defaults usage to instrumented method TypeName and MethodName. * Adds code level metrics enabled configuration defaulting to false.
…ntroller actions. (#1099)
* Adds user/customer code level span attributes for Web API 2. * Adds Owin hosted Web API 2 tests for CLM.
… code-level-metrics-feature-branch
* Add CLM for .NET MVC (Framework). Minor refactoring for performance. Commentary on possible work * Finalize impl * Integration tests * CR Feedback. Update integration test workflow to run Code Level Metrics tests
…rack down issues. (#1124) Adds waiting for span event log line. Prevents inlining for custom methods in AgentApiExecutor. Asserts individual span events where found.
nr-ahemsath
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed PR with @JcolemanNR and @michaelgoin. Found a few minor things to correct. Looks good to us. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability for the agent to sent Code Level Metrics to support the CodeStream integration. This is disabled by default, and must be enabled via
newrelic.config
or environment variable. When enabledcode.function
andcode.namespace
attributes are added to spans which enables the CodeStream IDE Plugin to display method execution information in code.Author Checklist
Reviewer Checklist