Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to change default behavior when tracking work on a new thread #1071

Merged
merged 8 commits into from
Apr 26, 2022

Conversation

JcolemanNR
Copy link
Contributor

@JcolemanNR JcolemanNR commented Apr 25, 2022

Description

Closes #347

This PR adds a new configuration option and environment variable to alter the default behavior of custom instrumentation in async scenarios where a transaction would be re-used.

When the configuration option is enabled, a new transaction will always be created for instrumented methods spawned on new threads.

Author Checklist

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)
  • Review Changelog

Copy link
Contributor

@vuqtran88 vuqtran88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JcolemanNR JcolemanNR merged commit e5513c7 into main Apr 26, 2022
@JcolemanNR JcolemanNR deleted the jcoleman/force-new-transaction-v2 branch April 26, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration option to change default behavior when tracking work on a new thread
2 participants