Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New StackExchange.Redis instrumentation incorrectly requires a transaction when initializing the SessionCache #1501

Closed
jaffinito opened this issue Mar 31, 2023 · 3 comments
Closed

New StackExchange.Redis instrumentation incorrectly requires a transaction when initializing the SessionCache #1501

jaffinito opened this issue Mar 31, 2023 · 3 comments
Assignees
@jaffinito
Labels
bug Something isn't working

Comments

@jaffinito
Copy link
Member

Description
ackExchange.Redis instrumentation incorrectly requires a transaction when initializing the SessionCache.
This portion of the instrumentation does not depend on a transaction and should not have IsTransactionRequired set to "true".
See:,

newrelic-dotnet-agent/src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/StackExchangeRedis2Plus/ConnectWrapperV2.cs

Line 14 in 23ee241

public bool IsTransactionRequired => true;

Expected Behavior
This always fires when reached, in or out of a transaction.

Steps to Reproduce
Make a call to CreateMulitplexor outside of a transaction.

For Maintainers Only or Hero Triaging this bug
Suggested Priority (P1,P2,P3,P4,P5): P4
Suggested T-Shirt size (S, M, L, XL, Unknown): XXXS
@jaffinito jaffinito added the bug Something isn't working label Mar 31, 2023
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-7898

@workato-integration
Copy link

Jira CommentId: 177384
Commented by jaffinito:

#1504

tippmar-nr added a commit that referenced this issue Apr 6, 2023
@jaffinito @nrcventura @tippmar-nr
summary: Resolves multiple issues with StackExchange.Redis v2+ profil…
925d016 
…ing (#1504)

fix: Allow StackExchange.Redis v2+ profiling to start outside of a transaction. (#1501 )
fix: Fix a memory leak when using StackExchange.Redis v2+. (#1473)
chore: Add more units tests
chore: Update logic to make better use of ConcurrentDictionary features.
chore: Mark weakTransaction as nullable.

---------

Co-authored-by: Chris Ventura <45495992+nrcventura@users.noreply.github.com>
Co-authored-by: Marty Tippin <120425148+tippmar-nr@users.noreply.github.com>
@chynesNR chynesNR mentioned this issue Apr 7, 2023
Merged
4 tasks
@github-actions github-actions bot mentioned this issue Apr 10, 2023
Merged
@workato-integration
Copy link

Work has been completed on this issue.

Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaffinito jaffinito

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaffinito