ci: Fix exception when creating GitHub issue in NugetVersionDeprecator (

#2280)
newrelic · Feb 28, 2024 · 61e200a · 61e200a
1 parent 7c1c34d
commit 61e200a
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 9 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -20,3 +20,7 @@ updates:
     directory: /src/NewRelic.Core
     schedule:
       interval: weekly
+  - package-ecosystem: nuget
+    directory: /build
+    schedule:
+      interval: weekly
diff --git a/build/NugetVersionDeprecator/NugetVersionDeprecator.csproj b/build/NugetVersionDeprecator/NugetVersionDeprecator.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net7.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
 
@@ -19,11 +19,11 @@
   <ItemGroup>
     <PackageReference Include="CommandLineParser" Version="2.9.1" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
-    <PackageReference Include="NuGet.Protocol" Version="6.6.1" />
-    <PackageReference Include="Octokit" Version="7.1.0" />
+    <PackageReference Include="NuGet.Protocol" Version="6.9.1" />
+    <PackageReference Include="Octokit" Version="10.0.0" />
     <PackageReference Include="RestSharp" Version="110.2.0" />
     <PackageReference Include="RestSharp.Serializers.NewtonsoftJson" Version="110.2.0" />
-    <PackageReference Include="YamlDotNet" Version="13.1.1" />
+    <PackageReference Include="YamlDotNet" Version="15.1.2" />
   </ItemGroup>
 
 </Project>
diff --git a/build/NugetVersionDeprecator/Program.cs b/build/NugetVersionDeprecator/Program.cs
@@ -1,4 +1,4 @@
-// Copyright 2023 New Relic, Inc. All rights reserved.
+// Copyright 2023 New Relic, Inc. All rights reserved.
 // SPDX-License-Identifier: Apache-2.0
 
 using System.Text;
@@ -54,7 +54,15 @@ static async Task<int> Main(string[] args)
                     Console.WriteLine(message);
 
                     if (!options.TestMode)
-                        await CreateGhIssueAsync(message, options.GithubToken);
+                    {
+                        var success = await CreateGhIssueAsync(message, options.GithubToken);
+                        if (!success)
+                        {
+                            Console.WriteLine("Error creating GitHub issue.");
+                            return -1;
+                        }
+                    }
+
                 }
             }
             else
@@ -155,7 +163,7 @@ p.DeprecationMetadata is null // not deprecated
             new PackageDeprecationInfo() { PackageName = p.PackageId, PackageVersion = p.Version.ToString() });
     }
 
-    static async Task CreateGhIssueAsync(string message, string githubToken)
+    static async Task<bool> CreateGhIssueAsync(string message, string githubToken)
     {
         var ghClient = new GitHubClient(new Octokit.ProductHeaderValue("NugetVersionDeprecator"));
         var tokenAuth = new Credentials(githubToken);
@@ -170,9 +178,18 @@ static async Task CreateGhIssueAsync(string message, string githubToken)
         newIssue.Labels.Add("Deprecation");
         newIssue.Labels.Add("Nuget");
 
-        var issue = await ghClient.Issue.Create("newrelic", "newrelic-dotnet-agent", newIssue);
+        try
+        {
+            var issue = await ghClient.Issue.Create("newrelic", "newrelic-dotnet-agent", newIssue);
+            Console.WriteLine($"Created new GitHub Issue #{issue.Number} with title {issue.Title}.");
+            return true;
+        }
+        catch (Exception ex)
+        {
+            Console.WriteLine($"Caught exception attepting to create GitHub issue: {ex.Message}.");
+            return false;
+        }
 
-        Console.WriteLine($"Created new GitHub Issue #{issue.Number} with title {issue.Title}.");
     }
 
     static Configuration LoadConfiguration(string path)