-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update original message to destination configurations #1177
Add update original message to destination configurations #1177
Conversation
@@ -30,7 +30,7 @@ func TestIntegrationCreateWorkflow(t *testing.T) { | |||
notificationTriggers := []AiWorkflowsNotificationTrigger{"ACTIVATED"} | |||
|
|||
// Create a workflow to work with in this test | |||
workflowInput := generateCreateWorkflowInput(channel, notificationTriggers) | |||
workflowInput := generateCreateWorkflowInput(channel, notificationTriggers, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly there's no real way to check the flag as it's only relevant for SLACK.
For the moment I'm just checking the fact that it's nil, but in the future we will expand its usage further so more tests can be done.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
- Coverage 38.84% 38.83% -0.01%
==========================================
Files 86 93 +7
Lines 5612 4722 -890
==========================================
- Hits 2180 1834 -346
+ Misses 3266 2715 -551
- Partials 166 173 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Added a new flag for the destination configurations, which can only be used and changed for slack.
The rest will be nil, future uses will be added later.