Add update original message to destination configurations #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzur-newrelic
commented
Jun 23, 2024
| @@ -30,7 +30,7 @@ func TestIntegrationCreateWorkflow(t *testing.T) { | |||
| notificationTriggers := []AiWorkflowsNotificationTrigger{"ACTIVATED"} | |||
|
|
|||
| // Create a workflow to work with in this test | |||
| workflowInput := generateCreateWorkflowInput(channel, notificationTriggers) | |||
| workflowInput := generateCreateWorkflowInput(channel, notificationTriggers, nil) | |||
There was a problem hiding this comment.
Sadly there's no real way to check the flag as it's only relevant for SLACK.
For the moment I'm just checking the fact that it's nil, but in the future we will expand its usage further so more tests can be done.
pranav-new-relic
approved these changes
Jun 26, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
- Coverage 38.84% 38.83% -0.01%
==========================================
Files 86 93 +7
Lines 5612 4722 -890
==========================================
- Hits 2180 1834 -346
+ Misses 3266 2715 -551
- Partials 166 173 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new flag for the destination configurations, which can only be used and changed for slack.
The rest will be nil, future uses will be added later.