Add support for OpenBSD #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
iamemilio
previously approved these changes
Feb 15, 2022
There was a problem hiding this comment.
This looks good to me, its nearly identical to what we support for freebsd, @RichVanderwal has verified that this works with OpenBSD in vagrant, go vet did not find any risky pointer conversions, and the tests look good. Thank you for the PR!
RichVanderwal
dismissed
iamemilio’s stale review
The base branch was changed.
|
Do I need to do anything else for this? |
iamemilio
approved these changes
May 10, 2022
qbit
added a commit
to qbit/certificates
that referenced
this pull request
Jul 28, 2022
OpenBSD support was added to the following deps: - github.com/go-piv/piv-go in go-piv/piv-go#101 - github.com/newrelic/go-agent in newrelic/go-agent#455 - github.com/miekg/pkcs11 in miekg/pkcs11#140 With these deps bumped, tests all pass on OpenBSD amd64.
qbit
added a commit
to qbit/certificates
that referenced
this pull request
Aug 4, 2022
OpenBSD support was added to the following deps: - github.com/go-piv/piv-go in go-piv/piv-go#101 - github.com/newrelic/go-agent in newrelic/go-agent#455 - github.com/miekg/pkcs11 in miekg/pkcs11#140 With these deps bumped, tests all pass on OpenBSD amd64.
qbit
added a commit
to qbit/certificates
that referenced
this pull request
Aug 4, 2022
OpenBSD support was added to the following deps: - github.com/go-piv/piv-go in go-piv/piv-go#101 - github.com/newrelic/go-agent in newrelic/go-agent#455 - github.com/miekg/pkcs11 in miekg/pkcs11#140 With these deps bumped, tests all pass on OpenBSD amd64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
PhysicalMemoryBytesfunctions and tests for OpenBSD.