Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support to honour proxy settings via config #236

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Conversation

sumitsuthar
Copy link
Contributor

Description

  • Implemented handling to pass proxy http agent in ws.
  • Now honouring proxy configurations provided in config file

How to Test

npm run test

Related Issues

Closes: NR-28857

Copy link
Contributor

@pratik-k2 pratik-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR has been tested in below proxy environments:
http (auth & non-auth)
https (auth & non-auth)
without proxy as well

@sumitsuthar sumitsuthar changed the title feat: Added support to honour proxy settings from config file feat: Added support to honour proxy settings via config Sep 4, 2024
@sumitsuthar sumitsuthar changed the title feat: Added support to honour proxy settings via config feat: Support to honour proxy settings via config Sep 4, 2024
@sumitsuthar sumitsuthar merged commit 092fbc4 into main Sep 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants