License data #8815
Open
License data #8815
+212
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FarazA22
force-pushed
the
licenseData
branch
3 times, most recently
from
470be0f
to
8f7107d
Compare
FarazA22
commented
Oct 2, 2024
| const licenseSearchEnabledTaskIds = Object.keys(taskIdLicenseNameMapping).sort(); | ||
|
|
||
| useEffect(() => { | ||
| if (process.env.NODE_ENV !== "development") { |
There was a problem hiding this comment.
is this the right variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach
https://www.pivotaltracker.com/story/show/188369690
Removed the CPA license name from the mapping object b/c the task no longer has license search enabled (we forgot to remove it).
https://www.pivotaltracker.com/story/show/188194087
I created a page that allows folks on the dev site to manipulate license data. If the environment variable is not development, the user will be routed back to the dashboard.
I was not able to add any unit tests because the environment variable when running jest is
test(it requires the env variable to be set to dev); manually changing the variable causes an error because the node environment variable is read-only. Since this functionality only works on dev, I think it's OK not to have any tests. JP is comfortable with it as well.I highly recommend visiting the site locally and making changes to license data. Once you have completed onboarding, visit http://localhost:3000/mgmt/modifyBusiness
Steps to Test
Notes
Code author checklist
userData(includingprofileData,formationDataetc), then I added a new migration filecmsCollections.ts(see CMS Additions in Engineering Reference/FAQ on the engineering documentation site).envvalues in both.env-templateand in Bitwarden