[DO NOT MERGE] Credential Engine launch #2415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ChelseaKR
force-pushed
the
credential-engine
branch
from
196d379 to
c609043
Compare
[NJWE-314, NJWE-1818] Switch average salary & % employed data to call to DB instead of CE
- Updated `getProviderData` in `CredentialEngineUtils.ts` to:
- Handle cases where `ceterms:ownedBy` is missing.
- Check for incomplete or invalid provider records (e.g., `{"errors":["Couldn't find Resource"]}`).
- Return `null` for missing providers with appropriate warnings.
- Adjusted `transformCertificateToTraining` in `searchTrainings.ts`:
- Added null checks for `provider`.
- Fallback to default values when `provider` is missing.
- Modified `findTrainingsBy.ts`:
- Ensured safe access to `provider` fields using null checks.
- Updated `Training` type to allow `provider` to be nullable.
- Enhanced TypeScript types:
- Updated `Training` and `Provider` interfaces to handle nullable `provider`.
- Frontend adjustments:
- Ensured components like `TrainingPage.tsx` and `TrainingResultCard.tsx` handle missing provider data gracefully.
- Added default text ("Provider not available") for missing provider information.
- Added warnings and logs for missing or invalid provider data.
- Resolved TypeScript compilation errors due to nullable `provider` fields.
This update ensures robust handling of scenarios where provider data is incomplete or missing, improving both backend and frontend stability.
- Updated `getProviderData` in `CredentialEngineUtils.ts` to:
- Handle cases where `ceterms:ownedBy` is missing.
- Check for incomplete or invalid provider records (e.g., `{"errors":["Couldn't find Resource"]}`).
- Return `null` for missing providers with appropriate warnings.
- Adjusted `transformCertificateToTraining` in `searchTrainings.ts`:
- Added null checks for `provider`.
- Fallback to default values when `provider` is missing.
- Modified `findTrainingsBy.ts`:
- Ensured safe access to `provider` fields using null checks.
- Updated `Training` type to allow `provider` to be nullable.
- Enhanced TypeScript types:
- Updated `Training` and `Provider` interfaces to handle nullable `provider`.
- Frontend adjustments:
- Ensured components like `TrainingPage.tsx` and `TrainingResultCard.tsx` handle missing provider data gracefully.
- Added default text ("Provider not available") for missing provider information.
- Added warnings and logs for missing or invalid provider data.
- Resolved TypeScript compilation errors due to nullable `provider` fields.
This update ensures robust handling of scenarios where provider data is incomplete or missing, improving both backend and frontend stability.
…onal-provider fix: Handle missing provider data gracefully across backend and frontend
NJWE-2550: Implemented language filter
…earch API calls and larger batch sizes - Refactored fetchAllCertsInBatches to execute batch requests concurrently. - Increased default batch size to 50 to minimize the number of API calls. - Combined all fetched results efficiently for reduced latency. - Improved scalability and performance of certificate fetching.
sending whitespace instead of "+" to search the entire query in the backend
- Added caching for provider data using NodeCache to reduce redundant API calls. - Fixed type mismatches in the Provider interface: - Updated the `addresses` property in the Provider interface to `Address[]`. - Ensured the `getAddress` function returns the correct structure, including the `@type` field. - Simplified mapping logic in `getProviderData` to directly use the output of `getAddress`. - Refactored related utilities to ensure compatibility with updated types. This improves performance by leveraging caching and resolves compilation errors caused by type inconsistencies.
- Replaced static import of `p-limit` with dynamic `import()` to ensure compatibility with AWS CommonJS(?) environment. - Updated `processInBatches` function to dynamically load `p-limit` only when needed. - This change ensures the code works seamlessly in both local (ES module) and AWS (CommonJS) environments.
implemented support services filter
…ntains matches for learning opportunity profile ceterms:name an ceterms:description
fix deliverytype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.