Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js-utility-ui-analytics source and imports #647

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

circlecube
Copy link
Member

also includes facebook module swap

Proposed changes

Updates js-utility-ui-analytics to npmjs hosted version.
Changes source in package file and associated imports in src files.
This also includes the facebook module update/migration to npmjs, but I see another PR for that already too.

Rather than have to lookup and import the js-utility-ui-analytics deps, I added @wordpress/data here, since it is required by the package and imported in the main util file with a comment. It just keeps it in the build asset dependency list.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

also includes facebook module swap
@circlecube circlecube requested a review from wpalani February 4, 2025 16:11
@circlecube circlecube self-assigned this Feb 4, 2025
@circlecube circlecube mentioned this pull request Feb 5, 2025
14 tasks
@circlecube circlecube merged commit 0983a57 into trunk Feb 5, 2025
5 checks passed
@wpalani wpalani mentioned this pull request Feb 14, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants