Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP Notice: wp_json_file_decode(): #639

Closed

Conversation

crodriguezbrito
Copy link
Contributor

Fix Change the path where it should look for the theme-i18.json file for different translations.

Proposed changes

This PR will fix the notice related to the wp_json_file_decode() function

PHP Notice: wp_json_file_decode(): File doesn't exist!

This fix updates the file path for locating the theme-i18.json file, ensuring that it retrieves the file from the correct location.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fix Change the path where it should look for the theme-i18.json file for different translations.
@wpscholar wpscholar requested a review from wpalani December 11, 2024 18:28
@crodriguezbrito
Copy link
Contributor Author

Hello @wpalani
When you have some time, could you review this PR?
Thanks for your time :)

@wpscholar
Copy link
Member

@crodriguezbrito - Please work with @circlecube to ensure the workflow gets fixed and passes. Once that is done, I think this should be good to merge.

@crodriguezbrito
Copy link
Contributor Author

closed in favour of #644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants