Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to all dismiss actions in a message #30

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Oct 9, 2024

Proposed changes

This should address a bug https://jira.newfold.com/browse/PRESS0-2274 when a user clicks "No Thanks" the modal closes but the messages is not dismissed.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

N/A

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

This should address a bug https://jira.newfold.com/browse/PRESS0-2274 when a user clicks "No Thanks" the modal closes but the messages is not dismissed.
@wpalani wpalani merged commit 1cf375e into main Oct 9, 2024
3 of 7 checks passed
@wpalani wpalani deleted the fix/multiple-dismiss-btns branch October 9, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants