Fix Scripts Not Working for Notifications #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes the JavaScript inside the <script> tag of notifications not working as expected in the brand plugin React apps by rendering the styles and scripts where they are expected to be, instead of inside the notifications container.
Also refer: https://github.com/newfold-labs/laravel-hiive/pull/421
Type of Change
Video
Issue:
Screen.Recording.2024-09-04.at.2.21.04.AM.mov
Fix:
Screen.Recording.2024-09-04.at.2.24.04.AM.mov
Checklist
Further comments