Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GobalCTB iframe dynamic sizing #18

Merged
merged 3 commits into from
Jun 25, 2024
+47 −7
Merged

GobalCTB iframe dynamic sizing #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b4f3fb
Dynamic iframe size
wpalani Jun 24, 2024
8b67e56
Test
wpalani Jun 24, 2024
d7a29ba
Remove local env specific flag
wpalani Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions static/ctb.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,11 @@ body.noscroll {
color: black;
display: flex;
justify-content: center;
align-items: center;
margin: auto;
max-height: 80vh;
max-height: 90dvh;
min-width: 960px;
max-width: 80vw;
max-width: 90vw;
padding: 0;
position: relative;
z-index: 2;
Expand All @@ -50,7 +51,7 @@ body.noscroll {
background-color: white;
min-height: 560px;
height: 100%;
max-height: 100%;
max-height: 90dvh;
width: 100%;
max-width: 100%;
border-radius: 5px;
Expand Down Expand Up @@ -120,13 +121,13 @@ body.noscroll {

@media screen and (max-width: 999px) {
.global-ctb-modal-content {
max-height: 100vh;
max-height: 100dvh;
max-width: 100vw;
min-height: 100vh;
min-height: 100dvh;
min-width: 100vw;
}
.global-ctb-modal iframe {
min-height: 100vh;
min-height: 100dvh;
border-radius: 0;
}
.global-ctb-modal-close {
Expand Down
13 changes: 13 additions & 0 deletions static/ctb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,19 @@
if (!event.origin.includes('hiive')) {
return;
}
if (event.data.type === 'frameWidth') {
// set iframe width
const iframe = document.querySelector('.global-ctb-modal-content iframe');
iframe.style.width = event.data.width;

// request iframe height
iframe.contentWindow.postMessage({ type: 'getFrameHeight' }, '*');
}
if (event.data.type === 'frameHeight') {
// set iframe height
const iframe = document.querySelector('.global-ctb-modal-content iframe');
iframe.style.height = event.data.height;
}
if (event.data === 'closeModal') {
closeModal();
}
Expand Down
28 changes: 27 additions & 1 deletion tests/cypress/integration/global-ctb.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe( 'Click to buy', function () {
.should( 'have.attr', 'target', '_blank' );
} );

it( 'CTB modal is functional', () => {
it( 'CTB modal opens successfully', () => {
cy.intercept(
{
method: 'GET',
Expand Down Expand Up @@ -79,7 +79,33 @@ describe( 'Click to buy', function () {
cy.get( '.global-ctb-modal-content iframe' )
.should( 'have.attr', 'src', 'https://example.com' )
.should( 'be.visible' );
} );

it( 'CTB iframe dynamic sizing works', () => {
// Mock the 'frameWidth' and 'frameHeight' message events
cy.window().then( ( win ) => {
// 'frameWidth' event
const widthEvent = new MessageEvent( 'message', {
data: { type: 'frameWidth', width: '800px' },
origin: 'http://hiive.com',
} );
win.dispatchEvent( widthEvent );

// 'frameHeight' event
const heightEvent = new MessageEvent( 'message', {
data: { type: 'frameHeight', height: '600px' },
origin: 'http://hiive.com',
} );
win.dispatchEvent( heightEvent );
} );

// check iframe width and height
cy.get( '.global-ctb-modal-content iframe' )
.should( 'have.css', 'width', '800px' )
.and( 'have.css', 'height', '600px' );
} );

it( 'X button closes CTB modal', () => {
// check that cancel button closes modal
cy.get( '.global-ctb-modal-close' ).click( { force: true } );
cy.wait( 200 );
Expand Down
Loading