Fix site capability transient filter issue #94
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
bootstrap.php
file to the data module, where other filters are located, and includes theis_callable
check. This approach is much safer.canMigrateSite
as the only capability set on any customer site.pre_set_transient
filter, which is a much safer option in this case (given 2). This filter checks for an empty value only when the transient is being set in the database, ensuring it is set only for sites where the Hiive API has failed.Type of Change
Video
Checklist
Further comments