Add coming soon hooks from ecommerce module #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpscholar
reviewed
Jan 3, 2024
* main: remove only-module-tests flags test only-module-tests in all cases test `only-module-tests` workflow flag add .nvmrc as v16 add brand plugin test workflow fix autofixable lint issues in test file Update Modal.jsx Update package.json Updated the approach to use the post status from wp.data Add translation Remove console.log Add pre-publish modal when coming soon is active # Conflicts: # includes/ComingSoon.php
|
This addresses issue #6 |
* main: remove unnecessary postcss config file Add missing package-lock file and postcss config Update API docs Code comments Update `comingSoon.isEnabled` to return boolean value or null on error JavaScript API and API routes Add service provider class to the container Update README.md Add new API docs # Conflicts: # package-lock.json
wpscholar
approved these changes
Jan 11, 2024
wpalani
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the coming soon hooks from the e-commerce module into the coming soon module so the coming soon module can own the coming soon functionality, logic and components.
See: newfold-labs/wp-module-ecommerce#199 where these are removed from ecom.