add subscribePosition to options and use mysql.format
#65
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| var ZongJi = require('./../'); | ||
| var getEventClass = require('./../lib/code_map').getEventClass; | ||
| var settings = require('./settings/mysql'); | ||
| var connector = require('./helpers/connector'); | ||
| var querySequence = require('./helpers/querySequence'); | ||
| var util = require('util') | ||
|
|
||
| var conn = process.testZongJi || {}; | ||
|
|
||
| module.exports = { | ||
| setUp: function (done) { | ||
| if (!conn.db) { | ||
| process.testZongJi = connector.call(conn, settings, done); | ||
| } else { | ||
| conn.incCount(); | ||
| done(); | ||
| } | ||
| }, | ||
| tearDown: function (done) { | ||
| if (conn) { | ||
| conn.eventLog.splice(0, conn.eventLog.length); | ||
| conn.errorLog.splice(0, conn.errorLog.length); | ||
| conn.closeIfInactive(1000); | ||
| } | ||
| done(); | ||
| }, | ||
| position: function (test) { | ||
| var TEST_TABLE = 'binlog_position'; | ||
| var events = []; | ||
|
|
||
| var zongji = new ZongJi(settings.connection); | ||
|
|
||
| var positions = [] | ||
| zongji.on('binlog', function(event){ | ||
| positions.push({ | ||
| filename: zongji.binlogName, | ||
| position: zongji.binlogNextPos | ||
| }) | ||
| }); | ||
| zongji.start({ | ||
| startAtEnd: true, | ||
| serverId: 10, // Second instance must not use same server ID | ||
| subscribePosition: true, | ||
| includeEvents: ['tablemap', 'writerows', 'updaterows', 'deleterows', 'rotate'] | ||
| }); | ||
|
|
||
| setTimeout(function() { | ||
| querySequence(conn.db, [ | ||
| 'FLUSH LOGS', | ||
| 'DROP TABLE IF EXISTS ' + conn.escId(TEST_TABLE), | ||
| 'CREATE TABLE ' + conn.escId(TEST_TABLE) + ' (col INT UNSIGNED)', | ||
| 'INSERT INTO ' + conn.escId(TEST_TABLE) + ' (col) VALUES (1)', | ||
| 'UPDATE ' + conn.escId(TEST_TABLE) + ' SET col=2', | ||
| 'DELETE FROM ' + conn.escId(TEST_TABLE), | ||
| 'FLUSH LOGS', | ||
| ], function (error, results) { | ||
| if (error) { | ||
| console.error(error); | ||
| zongji.stop(); | ||
| test.done(); | ||
| return; | ||
| } | ||
| // newer position should bigger than previous position | ||
| var lastPos; | ||
|
There was a problem hiding this comment. This is some spaghetti logic. If you're testing that the position increases with each event, just do it directly. var lastPos = null;
zongji.on('position', function() {
lastPos !== null && test.ok(zongji.binlogNextPos <= lastPos);
lastPos = zongji.binlogNextPos;
});You might also want to test that there are the correct number of position events. There was a problem hiding this comment. I have a consider of check the number of |
||
| for(var n=0; n<positions.length; n++){ | ||
| var item = positions[n]; | ||
| if(lastPos){ | ||
| if(item.filename == lastPos.filename){ | ||
| test.ok(item.position >= lastPos.position, util.format('same filename, position should increase, but from %s to %s', lastPos.position, item.position)); | ||
| }else{ | ||
| test.ok(item.filename > lastPos.filename, util.format('filename should increase, but from %s to %s', lastPos.filename, item.filename)); | ||
| } | ||
| } | ||
| lastPos = item; | ||
| } | ||
| zongji.stop(); | ||
| test.done(); | ||
| }) | ||
| }, 1000); | ||
| }, | ||
| subscribe_position: function (test) { | ||
|
There was a problem hiding this comment. What's the difference between these tests? |
||
| var TEST_TABLE = 'binlog_position'; | ||
| var events = []; | ||
|
|
||
| var zongji = new ZongJi(settings.connection); | ||
|
|
||
| var positions = [] | ||
| zongji.on('binlog_position', function(pos){ | ||
| positions.push(pos) | ||
| }); | ||
| zongji.start({ | ||
| startAtEnd: true, | ||
| serverId: 11, // Second instance must not use same server ID | ||
| subscribePosition: true, | ||
| includeEvents: ['tablemap', 'writerows', 'updaterows', 'deleterows', 'rotate'] | ||
| }); | ||
|
|
||
| setTimeout(function() { | ||
| querySequence(conn.db, [ | ||
| 'FLUSH LOGS', | ||
| 'DROP TABLE IF EXISTS ' + conn.escId(TEST_TABLE), | ||
| 'CREATE TABLE ' + conn.escId(TEST_TABLE) + ' (col INT UNSIGNED)', | ||
| 'INSERT INTO ' + conn.escId(TEST_TABLE) + ' (col) VALUES (1)', | ||
| 'UPDATE ' + conn.escId(TEST_TABLE) + ' SET col=2', | ||
| 'DELETE FROM ' + conn.escId(TEST_TABLE), | ||
| 'FLUSH LOGS', | ||
| ], function (error, results) { | ||
| if (error) { | ||
| console.error(error); | ||
| zongji.stop(); | ||
| test.done(); | ||
| return; | ||
| } | ||
| // newer position should bigger than previous position | ||
| var lastPos; | ||
| for(var n=0; n<positions.length; n++){ | ||
| var item = positions[n]; | ||
| if(lastPos){ | ||
| if(item.filename == lastPos.filename){ | ||
| test.ok(item.position > lastPos.position, util.format('same filename, position should increase, but from %s to %s', lastPos.position, item.position)); | ||
| }else{ | ||
| test.ok(item.filename > lastPos.filename, util.format('filename should increase, but from %s to %s', lastPos.filename, item.filename)); | ||
| } | ||
| } | ||
| lastPos = item; | ||
| } | ||
| zongji.stop(); | ||
| test.done(); | ||
| }) | ||
| }, 1000); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of a section here, create a section just above
**Options Available:**for**Events Emitted:**and take out the current text for theonmethod to bind handlers: