Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support "*" for include config. #146

Merged
merged 3 commits into from
Feb 25, 2021
Merged

feat: support "*" for include config. #146

merged 3 commits into from
Feb 25, 2021

Conversation

neverendingqs
Copy link
Owner

@neverendingqs neverendingqs commented Feb 25, 2021 •
edited
Loading

Description

This change will make it easier to implement #89.

Checklist

  • CHANGELOG.md
  • README.md
  • Unit tests
  • Consider performance implications
  • Consider security implications

Exploratory Test Notes

  • Confirmed setting include to [] means no env vars are added to the global environment as expected
  • Confirmed setting include to * means all env vars are added to the global environment as expected
  • Confirmed not setting include means all env vars are added to the global environment as expected

@neverendingqs neverendingqs marked this pull request as ready for review February 25, 2021 03:16
@neverendingqs neverendingqs merged commit 92747d7 into master Feb 25, 2021
@neverendingqs neverendingqs deleted the feat/supportstar branch February 25, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@neverendingqs