Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding variableExpansion option to turn off variable expansion. #116

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

neverendingqs
Copy link
Owner

@neverendingqs neverendingqs commented Feb 10, 2021

Description

Resolves #90. This pull request adds an option to turn off variable expansion (but leaves it on by default).

Checklist

  • CHANGELOG.md
  • README.md
  • Unit tests
  • Consider performance implications
  • Consider security implications

Exploratory Test Notes

Using a .env file with the following contents:

INNER_ENV=innerenv
OUTER_ENV=hi-$INNER_ENV
custom:
  dotenv:
    variableExpansion: false

results in { INNER_ENV: 'innerenv', OUTER_ENV: 'hi-$INNER_ENV' } as expected.

custom:
  dotenv:
    required:
      file: true

results in { INNER_ENV: 'innerenv', OUTER_ENV: 'hi-innerenv' } as expected.

No custom.dotenv property inside serverless.yml results in { INNER_ENV: 'innerenv', OUTER_ENV: 'hi-innerenv' } as expected.

@neverendingqs neverendingqs changed the title feat: adding variableExpansion. feat: adding variableExpansion option to turn off variable expansion. Feb 10, 2021
@neverendingqs neverendingqs marked this pull request as ready for review February 10, 2021 03:18
@neverendingqs neverendingqs merged commit 3fc832e into master Feb 10, 2021
@neverendingqs neverendingqs deleted the feat/varexpansionflag branch February 10, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to bypass dotenv-expand.
1 participant