Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lockdrop vault NTRN-343 #35

Merged
merged 11 commits into from
Feb 21, 2023

Conversation

sotnikov-s
Copy link
Contributor

@sotnikov-s sotnikov-s commented Jan 31, 2023

task: https://p2pvalidator.atlassian.net/browse/NTRN-343

this PR:

  • adds a half-implemented lockdrop vault contract;
  • makes a kind of unique query and execute interface for a voting vault and applies it to the old neutron voting vault and the new lockdrop vault;
  • expands the above-mentioned query interface with new messages: Name which returns the vault's name, and BondingStatus which returns whether the vault is open for bonding and whether the address is eligible for unbonding funds.

relative PRs:

tests run: https://github.com/neutron-org/neutron-tests/actions/runs/4231771709

@sotnikov-s sotnikov-s changed the base branch from main to neutron_audit_informal_17_01_2023 January 31, 2023 10:25
@sotnikov-s sotnikov-s force-pushed the feat/add-lockdrop-vault branch from 6de98b6 to 19bdf02 Compare January 31, 2023 10:30
Comment on lines +20 to +21
cw-storage-plus = "0.13"
cw2 = "0.13"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use version 1.0.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created a task to update it across the whole repo: https://p2pvalidator.atlassian.net/browse/NTRN-381

Copy link
Collaborator

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with clarification, that core mechanism of querying voting power at height is not implemented yet

…n-org/neutron-dao into feat/add-lockdrop-vault
@zavgorodnii zavgorodnii merged commit 9181d56 into neutron_audit_informal_17_01_2023 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants