log: change date format to ISO8601-like #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, |
|
I'm thinking of creating new function like this: const char *
getFormattedTime()
{
static char buffer[32];
static char buf_datetime[21];
static char buf_millisec[4];
static char buf_timezone[6];
struct tm *now;
struct timeval tv;
int millisec;
gettimeofday(&tv, NULL);
now = localtime(&tv.tv_sec);
millisec = lrint(tv.tv_usec / 1000.0);
sprintf(buf_millisec, "%03d", millisec);
strftime(buf_datetime, sizeof(buf_datetime), "%FT%T.", now);
strftime(buf_timezone, sizeof(buf_timezone), "%z", now);
sprintf(buffer, "[%s%s%s] ", buf_datetime, buf_millisec, buf_timezone);
return buffer;
} |
metalefty
force-pushed
the
log_time
branch
4 times, most recently
from
ad4afe6 to
62dd78b
Compare
|
@aquesnel Can you also have a look? You worked hard on logging. |
matt335672
reviewed
Oct 10, 2022
Former format: "[20221007-16:36:02] " New format: "[2022-10-07T16:36:04.357+0900] "
matt335672
approved these changes
Oct 12, 2022
aquesnel
approved these changes
Oct 27, 2022
metalefty
added a commit
to metalefty/xrdp
that referenced
this pull request
Feb 9, 2023
The tail of new datetime format was sticking out.
metalefty
added a commit
to metalefty/xrdp
that referenced
this pull request
Feb 9, 2023
The tail of new datetime format was sticking out.
metalefty
added a commit
that referenced
this pull request
Feb 10, 2023
log: fix syslog glitch after #2386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Former format: "[20221007-16:36:02] "
New format: "[2022-10-07T16:36:04.357+0900] "
Two reasons for this change:
While I was debugging, I want to add msec for more precision. However, this will break backward compatibility. I think logs are mostly read by human so compatibility is not a serious problem. Any opinions?
The difference between the true ISO 8601 and this format is msec. The true ISO 8601 doesn't include msec.
Finally, I get the following log.
xrdp-sesman.log
xrdp.log