Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify logging in vnc/* #1811

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Conversation

aquesnel
Copy link
Contributor

Follow-on pull request to #1633 which migrates all logging in the vnc directory to use the LOG() and LOG_DEVEL() macros.

Changes:

  • Migrate logging to the LOG() and LOG_DEVEL() macros (using text transform script)
  • error logs use the LOG macro
  • update code formatting with astyle for all files in xrdp/*

@aquesnel aquesnel changed the title Migrating logging to LOG() and LOG_DEVEL() in vnc/* Unify logging in vnc/* Feb 23, 2021
Copy link
Member

@matt335672 matt335672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work as ever. Two minor comments.

@aquesnel
Copy link
Contributor Author

aquesnel commented Mar 1, 2021

@matt335672 I've implemented the feedback, let me know if anything else needs to be changed before this can be merged.

@matt335672 matt335672 merged commit def72ac into neutrinolabs:devel Mar 1, 2021
@aquesnel aquesnel deleted the unify_logging_vnc branch March 6, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants