Ignore TS_MULTIFRAGMENTUPDATE_CAPABILITYSET from client if fp disabled #1593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1569
rdesktop 1.9.0 (as delivered with Ubuntu 20.04) sends a TS_MULTIFRAGMENTUPDATE_CAPABILITYSET structure ([MS-RDPBCGR] 2.2.7.2.6) with a MaxRequestSize of 65535.
If the user has disabled fastpath output using
use_fastpath
inxrdp.ini
, the following happens:-xrdp_orders_create()
.xrdp_caps_process_multifragmentupdate()
setsclient_info.max_fastpath_frag_bytes
to 65535.xrdp_orders_check()
va theMAX_ORDERS_SIZE
macro to determine when to send the orders buffer. Consequently the buffer overflows when being written to.This PR simply ignores any sent
MaxRequestSize
value if fastpath output is disabled.