Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drive redirect fixes, including Guacamole #1507

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

matt335672
Copy link
Member

Minor bug fixes to drive redirection

  • Support a DeviceId of 0 in a DEVICE_ANNOUNCE header. This is required by the Guacamole client and fixes drive redirection issues with guacamole #1505
  • DR_CORE_DEVICE_ANNOUNCE_RSP messages are now sent to the server for unsupported devices - these were previously ignored
  • Read errors on remote files are now returned to the reader, rather than just a read with a length of zero.
  • Improved a number of returned error codes to be more standards compliant. In particular, the Linux mv command is now able to make use of EXDEV to provide move between devices. Also, the .clipboard directory cannot be modified intentionally or unintentionally by the user as it appears to be read-only.
  • Added additional pointer checks to xfs_get_full_path() to prevent a coredump in the event of a corrupted filesystem.

This PR contains two commits; the #1505 fixes are in one, and the other fixes are in the other. The #1505 fix has been verified as part of that issue report.

@metalefty metalefty merged commit a57e777 into neutrinolabs:devel Mar 11, 2020
@matt335672 matt335672 deleted the drive-redirect-fixes branch March 15, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drive redirection issues with guacamole
2 participants