Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated initialization of variable in xrdp_bitmap.c #1909

Closed
qarmin opened this issue Jun 3, 2021 · 2 comments
Closed

Duplicated initialization of variable in xrdp_bitmap.c #1909

qarmin opened this issue Jun 3, 2021 · 2 comments

Comments

@qarmin
Copy link
Contributor

qarmin commented Jun 3, 2021

xrdp/xrdp/xrdp_bitmap.c

Lines 1359 to 1360 in 7d8f084

painter->brush.x_origin = x;
painter->brush.x_origin = x;

@metalefty
Copy link
Member

Thanks for the catch. Can you make a pull request? Then we'll merge your contribution soon.

@matt335672
Copy link
Member

Agreed.

It looks to me like this was intended to be a setting of brush.y_origin cut-and-pasted from the previous line that wasn't finished.

metalefty added a commit to metalefty/xrdp that referenced this issue Sep 22, 2021
matt335672 added a commit that referenced this issue Sep 22, 2021
Fix duplicated initialization #1909
derekschrock pushed a commit to derekschrock/xrdp that referenced this issue Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants