This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Move @neutrinojs/env into the web preset & support default values #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `EnvironmentPlugin` doesn't require any non-webpack dependencies or complex configuration, it's simpler to inline the plugin directly in presets that use it (which is currently just the web preset). The argument passed to the plugin is now correctly wrapped in an array (as expected by `webpack-chain`), meaning the object form that allows setting defaults is now also supported: https://webpack.js.org/plugins/environment-plugin/#usage-with-default-values Closes #657.
|
With this PR, we now have 6 fewer lower-level presets on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
EnvironmentPlugindoesn't require any non-webpack dependencies or complex configuration, it's simpler to inline the plugin directly in presets that use it (which is currently just the web preset).The argument passed to the plugin is now correctly wrapped in an array (as expected by
webpack-chain), meaning the object form that allows setting defaults is now also supported:https://webpack.js.org/plugins/environment-plugin/#usage-with-default-values
The options change is non-breaking, however the removal of
@neutrinojs/envis, for people who used it directly.Closes #657.