Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Revert to earlier version of babel-minify-webpack-plugin due to sourcemap errors #579

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Revert to earlier version of babel-minify-webpack-plugin due to sourcemap errors #579

merged 1 commit into from
Dec 8, 2017

Conversation

eliperelman
Copy link
Member

Fixes #578.

This is a workaround for webpack-contrib/babel-minify-webpack-plugin#68 until that issue is fixed. Right now we are pinning to a previous version.

@eliperelman eliperelman requested a review from a team December 8, 2017 18:15
@eliperelman eliperelman added the bug label Dec 8, 2017
@helfi92
Copy link
Member

helfi92 commented Dec 8, 2017

If we're no longer using babel-minify, should the package name be changed to something else?

@eliperelman
Copy link
Member Author

We are just using an older version of it, we are still using it.

@helfi92
Copy link
Member

helfi92 commented Dec 8, 2017

Sounds good.

@eliperelman
Copy link
Member Author

And the name of the package is a reference to what we are doing, rather than what it contains. We are doing a babel minify, just like image-minify minifies images, rather than reference the imagemin plugin.

@eliperelman eliperelman merged commit af814c1 into neutrinojs:master Dec 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

Error generating source map with react-components preset
2 participants