This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Simplify require_test.js, making it pass on Windows #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the test would consistently fail on Windows due to it attempting to remove the `test-modules` directory before the `chdir()` call to reset the working directory. Subsequent runs would additionally hit ava test discovery errors due to it seeing the leftover `test-modules` directory as a test rather than a fixture. Whilst these issues could be fixed by inverting the cleanup order, it makes more sense to commit the `test-module` files to the repo rather than generate them on the fly. They have been moved under the `fixtures` directory to avoid the above ava errors. The test cleanup `chdir(cwd)` step has also been removed, since ava runs each test file in a new process, meaning no tests will run after it anyway. Fixes #336.
eliperelman
approved these changes
Sep 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the test would consistently fail on Windows due to it attempting to remove the
test-modulesdirectory before thechdir()call to reset the working directory. Subsequent runs would additionally hit ava test discovery errors due to it seeing the leftovertest-modulesdirectory as a test rather than a fixture.Whilst these issues could be fixed by inverting the cleanup order, it makes more sense to commit the
test-modulefiles to the repo rather than generate them on the fly. They have been moved under thefixturesdirectory to avoid the above ava errors.The test cleanup
chdir(cwd)step has also been removed, since ava runs each test file in a new process, meaning no tests will run after it anyway.Fixes #336.