This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Ensure test cases are not run 2x in watch mode. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
reviewed
Jun 23, 2017
| files: [tests], | ||
| files: [{ | ||
| pattern: tests, | ||
| watched: false, |
There was a problem hiding this comment.
Should watched be driven by the args.watch?
There was a problem hiding this comment.
It should never be watched... The compiled test files are watched and that is all that is needed. No need to additionally watch the test src files.
jaridmargolin
force-pushed
the
karma-watch-fix
branch
from
6a76338 to
7d34857
Compare
eliperelman
approved these changes
Jun 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, modifications of test files resulted in test cases being run 2x.
Reference: nikku/karma-browserify#67 (comment)