Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Support options for jest and karma presets in v9 #1081

Merged
merged 2 commits into from
Sep 7, 2018

Conversation

eliperelman
Copy link
Member

Fixes #907.

This patch re-introduces the ability to pass options to the jest and karma presets. It does not support options for mocha since mocha has no configuration file to be able to pass options to.

@eliperelman eliperelman added the bug label Sep 6, 2018
@eliperelman eliperelman added this to the v9 milestone Sep 6, 2018
@eliperelman eliperelman self-assigned this Sep 6, 2018
@eliperelman eliperelman requested a review from edmorley September 6, 2018 18:46
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

If it's not too much trouble, could you add a quick test for each, showing that the passed options can override an existing option property?

@eliperelman eliperelman merged commit 4de016f into neutrinojs:master Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants