Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Update dependency babel-merge to v2 #1002

Closed
wants to merge 2 commits into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 20, 2018

This Pull Request updates dependency babel-merge from ^1.1.1 to ^2.0.0


Release Notes

v2.0.0

Compare Source



This PR has been generated by Renovate Bot.

@edmorley edmorley requested a review from eliperelman July 23, 2018 12:03
@eliperelman
Copy link
Member

There may be a couple changes to make from this, but possibly not. I'm going to wait on a README update by the original patch author before moving forward on this.

@renovate
Copy link
Contributor Author

renovate bot commented Aug 6, 2018

PR has been edited

As this PR has been edited, Renovate will stop updating it in order to not cause any conflicts or other problems. If you wish to abandon your edits and have Renovate recreate this PR then you should rename this PR and then close it.

@edmorley
Copy link
Member

@eliperelman is this good to merge after a rebase? To clarify - the change in merge behaviour is breaking, but not in a way that means we need to update anything in this repo, right? :-)

@eliperelman eliperelman force-pushed the renovate/babel-merge-2.x branch from 582acf1 to ba9145f Compare August 15, 2018 16:35
@eliperelman
Copy link
Member

@edmorley I believe so; I went through all of our usages of compileLoader.merge to see if we were relying on overriding option passing to plugins and presets, which is the breaking change, and couldn't find anything relevant. Once CI passes, we can merge.

@eliperelman eliperelman reopened this Aug 15, 2018
@renovate
Copy link
Contributor Author

renovate bot commented Aug 15, 2018

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 2.x releases. However, if you upgrade to 2.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot closed this Aug 15, 2018
@renovate renovate bot deleted the renovate/babel-merge-2.x branch August 15, 2018 16:37
@eliperelman
Copy link
Member

wtf

@eliperelman eliperelman restored the renovate/babel-merge-2.x branch August 15, 2018 16:48
@renovate renovate bot deleted the renovate/babel-merge-2.x branch August 15, 2018 16:48
@eliperelman
Copy link
Member

omfg

@eliperelman eliperelman restored the renovate/babel-merge-2.x branch August 15, 2018 16:49
@eliperelman eliperelman reopened this Aug 15, 2018
@renovate renovate bot closed this Aug 15, 2018
@renovate renovate bot deleted the renovate/babel-merge-2.x branch August 15, 2018 16:49
@edmorley
Copy link
Member

Give the branch a new name for now and I'll file an issue against Renovate.

@edmorley
Copy link
Member

(Renovate has a "check if a human has edited a branch, and if so stop touching it" feature, which might have been confused by the force push rebase)

@eliperelman
Copy link
Member

Interesting. Yeah I opened a new branch, just waiting on CI. 😜

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants