Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add twitter account on software cards #68

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

RignonNoel
Copy link
Contributor

@RignonNoel RignonNoel commented Jun 20, 2022

fix #53

I decided to remove the stars label of Github to reduce the space needed and enhance the responsive. But feel free to request changes on the PR if you think it's a bad idea.

I also fixed a bug with the condition of Github repository link, the condition was on the value and not on the fact that the variable exist or not in the item of the .yml. The cards now work even without github link.

@RignonNoel
Copy link
Contributor Author

Here are some screenshots to help you review @jcohenadad

Before
Firefox_Screenshot_2022-06-28T15-14-07 413Z

After
Firefox_Screenshot_2022-06-28T15-13-54 273Z

@jcohenadad
Copy link
Member

You can probably remove the button "repo" because it is already there on the right

@RignonNoel
Copy link
Contributor Author

RignonNoel commented Jun 28, 2022

@jcohenadad Here is the version without the repo button:

Firefox_Screenshot_2022-06-28T19-30-20 900Z

Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. Did you want to open another issue to maybe replace the ugly "website" button with a button that has a similar look as the twitter and github buttons, and that would have a 'documentation' icon?

@jcohenadad jcohenadad merged commit 0c4c6d0 into master Jun 28, 2022
@jcohenadad jcohenadad deleted the nr/add_twitter_account_on_software branch June 28, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add twitter handle for each software package
2 participants