[ENH] - Plotting updates #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhammonds
approved these changes
Dec 12, 2024
|
|
||
| @savefig | ||
| @style_plot | ||
| def plot_autocorr(timepoints, autocorrs, labels=None, colors=None, ax=None, **kwargs): |
There was a problem hiding this comment.
Only thought here is whether to include it in aperiodic.py or somewhere else, since acf isn't restricted to aperiodic signals.
| ... 'sim_bursty_oscillation' : {'freq': 10}}) | ||
| >>> freqs1, powers1 = compute_spectrum(sig1, fs=500) | ||
| >>> freqs2, powers2 = compute_spectrum(sig2, fs=500) | ||
| >>> plot_spectra_3D([freqs1, freqs2], [powers1, powers2]) |
There was a problem hiding this comment.
I noticed the z-axis label is cutoff when I copy/paste the example into a notebook. I tried plt.tight_layout() but it gave an error about the size of the fig not having large enough margins. Maybe a solution would be to add an ax or fig kwarg
|
|
||
| @savefig | ||
| @style_plot | ||
| def plot_spectra_3D(freqs, powers, log_freqs=False, log_powers=True, |
There was a problem hiding this comment.
Should this be added to __init__.py?
| else: | ||
| labels = repeat(labels) | ||
|
|
||
| colors = repeat(colors) if not isinstance(colors, list) else cycle(colors) |
There was a problem hiding this comment.
The docstring for colors and labels says it accepts iterables, but this may break with tuple/array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and extends some plotting code. It adds to neurodsp some code I developed in the AperiodicHistory project, which I think are general enough to be added her.
Main updates:
prepare_multi_plotwhich consolidates the same process we had in multiple places for supporting plots that may (or may not) have multiple inputs (e.g. plotting multiple spectra on the same plot)plot_autocorrplotplot_spectra_3Dplot