-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - Simulation updates #336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing this!
I read through everything here, except for the tests. I think this and the last, related PR, will be useful for running parameter grids of simulations! I left minor comments but everything looked good at a high level.
I was working on something similar here a while ago. The approach here accomplishes the same. I like that you've added parameter sampling too.
The only other thing, that doesn't necessarily need to be addressed here but maybe for something in the future, is parallelization over grids. I think here iterates over sets of parameters serially, maybe a multiprocessing pool could be used if scaling is a concern.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
+ Coverage 98.02% 98.24% +0.22%
==========================================
Files 110 115 +5
Lines 3995 4327 +332
==========================================
+ Hits 3916 4251 +335
+ Misses 79 76 -3 ☔ View full report in Codecov by Sentry. |
@ryanhammonds - thanks for checking in on this! I should have totally had a look what was available in Also agreed on adding parallel support - I think that would be a great extension! For now, I'll merge this in! |
This is an update through the new simulation functionality added in #329
Most of the updates are cleaning up and improving consistency across the
sim
module. This includes moving some functions around and re-organization sim sub-modules. A notable update is the adding simulation I/O functionality, so that simulations can be saved and loaded.