Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task unaware xor vs rxor random forest bootstrap experiment #544

Open
wants to merge 33 commits into
base: staging
Choose a base branch
from

Conversation

kfenggg
Copy link
Contributor

@kfenggg kfenggg commented May 7, 2022

Reference issue

Experiment for task unaware learning.

Type of change

Add jupyter notebook containing experiment and functions file to run the experiment.

What does this implement/fix?

Adds an experiment that explores when xor and rxor are different enough to train a new random forest.

Additional information

@PSSF23 PSSF23 requested a review from jdey4 May 9, 2022 15:19
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black formatting needed. Also the file name is quite long. You can make it shorter.

@jdey4
Copy link
Collaborator

jdey4 commented May 9, 2022

Please do not print 10,20,30... in the notebook.

@kfenggg
Copy link
Contributor Author

kfenggg commented May 9, 2022

black formatting needed. Also the file name is quite long. You can make it shorter.

Fixed

@kfenggg
Copy link
Contributor Author

kfenggg commented May 9, 2022

Please do not print 10,20,30... in the notebook.

Fixed

@kfenggg kfenggg requested a review from PSSF23 May 9, 2022 16:37
@PSSF23
Copy link
Member

PSSF23 commented May 9, 2022

black formatting needed. Also the file name is quite long. You can make it shorter.

Fixed

Nope~

@kfenggg
Copy link
Contributor Author

kfenggg commented May 9, 2022

black formatting needed. Also the file name is quite long. You can make it shorter.

Fixed

Nope~

Are both files still formatted incorrectly? I ran black on the functions file and jblack on the notebook.

Edit: I just reran both, I think there were some changes made to the notebook so I reuploaded that. Please, let me know if there is still a problem.

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfenggg Check not passed. You can take a look yourself. black works for jupyter notebooks natively. Other packages will not pass.

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #544 (58d71e1) into staging (acec608) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           staging     #544   +/-   ##
========================================
  Coverage    90.09%   90.09%           
========================================
  Files            7        7           
  Lines          404      404           
========================================
  Hits           364      364           
  Misses          40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acec608...58d71e1. Read the comment docs.

@kfenggg kfenggg requested a review from PSSF23 May 10, 2022 00:20
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @kfenggg Actually you can make the title shorter and more consistent as other XOR experiments: https://proglearn.neurodata.io/experiments/xor_rxor_exp.html. You should also add subsections to make the tutorial more readable.

@jdey4 your thoughts?

@kfenggg kfenggg requested a review from PSSF23 May 10, 2022 00:41
@jdey4
Copy link
Collaborator

jdey4 commented May 17, 2022

I think, this PR needs more work to publish it in the main or staging branch. But this is good for doing the grading. We can save the PR in a separate branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants