Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] remove --no-progress-meter everywhere in script #253

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Jan 10, 2024

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@coveralls
Copy link
Collaborator

coveralls commented Jan 10, 2024

Pull Request Test Coverage Report for Build 7480169909

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.771%

Totals Coverage Status
Change from base Build 7176777641: 0.0%
Covered Lines: 873
Relevant Lines: 875

💛 - Coveralls

@surchs surchs self-requested a review January 11, 2024 02:20
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good 🧑‍🍳

Not quite sure what pre-commit is on about (can't find docker compose), mind checking that before merging?

@alyssadai
Copy link
Contributor Author

Thanks @surchs! I've looked into the pre-commit failure an opened an issue: #254

Have a look and let me know WYT re: keeping this PR open until we address the above, or just merging with the failed check for now.

@surchs
Copy link
Contributor

surchs commented Jan 11, 2024

I'd say merge with the failed check because we now have the issue to fix pre-commit soon

@alyssadai alyssadai merged commit 3b3747b into main Jan 11, 2024
5 of 6 checks passed
@alyssadai alyssadai deleted the alyssadai-patch-1 branch January 11, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_data_to_graph.sh still errors out for older curl versions
3 participants