ENG-620: project-based namespaces #630
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #630 +/- ##
===========================================
- Coverage 93.46% 21.57% -71.90%
===========================================
Files 7 7
Lines 597 445 -152
Branches 36 19 -17
===========================================
- Hits 558 96 -462
- Misses 30 349 +319
+ Partials 9 0 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| + org_project_validator | ||
| ) | ||
|
|
||
| secret_response_validator = ( |
There was a problem hiding this comment.
I think we can remove response validator
platform_secrets/validators.py
Outdated
| t.Key("target_namespace"): t.String(min_length=1, max_length=253), | ||
| t.Key("secret_names"): t.List(t.String(), min_length=1), | ||
| } | ||
| secret_unwrap_validator = ( |
There was a problem hiding this comment.
do we need this? since you deleted /copy endpoint
There was a problem hiding this comment.
@zubenkoivan sure. removed
platform_secrets/service.py
Outdated
| @@ -24,6 +25,10 @@ | |||
| NAMESPACE_PROJECT_LABEL = "platform.apolo.us/project" | |||
|
|
|||
|
|
|||
| def generate_namespace_name(org_name: str, project_name: str) -> str: | |||
| return f"platform--{org_name}--{project_name}" | |||
There was a problem hiding this comment.
this combination can be larger than 253 characters. I think we will need to concatenate substring of the full name with the substring of the full name hash to avoid name conflicts
There was a problem hiding this comment.
@zubenkoivan pushed a new version of that function. Please check
No description provided.