Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marlin MoE integration #2

Closed
wants to merge 111 commits into from
Closed

Marlin MoE integration #2

wants to merge 111 commits into from

Conversation

ElizaWszola
Copy link

@ElizaWszola ElizaWszola commented Aug 2, 2024

Reimplement quantized Mixtral to combine Marlin kernels with fused MoE.

Unit testing:

pytest tests/kernels/test_moe.py -k test_fused_marlin_moe

End-to-end testing:
Run offline_inference.py with

// quantized moe with act order
llm = LLM(model="TheBloke/Mixtral-8x7B-v0.1-GPTQ",
          revision="gptq-4bit-128g-actorder_True")

and

// quantized moe without act order
llm = LLM(model="TheBloke/Mixtral-8x7B-v0.1-GPTQ")

Sonnet benchmark results (no act order):

TTFT TPOT
vLLM_ TTFT, Mixtral 8x7B 4-bit vLLM_ TPOT, Mixtral 8x7B 4-bit-2
vLLM_ TTFT, Mixtral 8x7B 4-bit-2 vLLM_ TPOT, Mixtral 8x7B 4-bit-3
vLLM_ TTFT, Mixtral 8x7B 4-bit-3 vLLM_ TPOT, Mixtral 8x7B 4-bit

Copy link

github-actions bot commented Aug 2, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@alexm-neuralmagic
Copy link

@alexm-neuralmagic
Copy link

Eliza will redirect to vllm directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants