Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[analytics] use 'nightly' for version datestamps #406

Merged
merged 2 commits into from
Dec 18, 2023
Merged

[analytics] use 'nightly' for version datestamps #406

merged 2 commits into from
Dec 18, 2023

Conversation

bfineran
Copy link
Contributor

@bfineran bfineran commented Dec 5, 2023

to allow for easier aggregation/comparison of nightly analytics

>>> from sparsezoo.version import version as sparsezoo_version
>>> _maybe_replace_nightly_date(sparsezoo_version)
'1.6.0.nightly'

@bfineran bfineran requested a review from markurtz December 5, 2023 21:02
@bfineran bfineran self-assigned this Dec 5, 2023
@bfineran bfineran merged commit c035b5b into main Dec 18, 2023
4 checks passed
@bfineran bfineran deleted the analytics-nightly-version-standardization branch December 18, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbogunowicz dbogunowicz dbogunowicz approved these changes

@markurtz markurtz Awaiting requested review from markurtz

Assignees

@bfineran bfineran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfineran @dbogunowicz