[analytics] Made suppression fixes #324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the requested suppression fixes, the work is two fold:
request
andurllib3
loggers: Added a context manager for thatis_gdpr_country
: Accomplished usingcontextlib.redirect_stderr()
After this change me and @KSGulin verified locally that output was still produced by utilities such as
deepsparse.check_hardware
:And also that integration tests for deepsparse are green ✅
(sparsezoo) 🥃 deepsparse (main) 💍 make test_integrations Running package integrations tests =========================================================================== test session starts =========================================================================== platform linux -- Python 3.10.11, pytest-7.3.1, pluggy-1.0.0 rootdir: /home/rahul/github_projects/deepsparse configfile: pyproject.toml plugins: flaky-3.7.0, anyio-3.7.0 collected 2 items integrations/haystack/tests/test_smoke.py .. [100%]
Noting: It will take time for
local-install-checks
here indeepsparse
to be green as they installsparsezoo nightly
directly from pypiAlso ran the following to verify:
Output: