Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts commit
https://github.com/neuralmagic/sparsezoo/commit/960cae23e8273cc7e3cfff9ceb65a8f3ecb8628f.
The newly added GoogleAnalytics class was throwing
429 Client Errors:
a proposed fix for that was to suppress sys.stdout and sys.stderr streams in a multithreaded function, The problem with this fix was that the streams were not being restored properly and were suppressing output from all commands, and raised a 120 error code a potential fix could be toI wasn't able to reproduce the exact error 429 Client Error from GoogleAnalytics request but raised a dummy HTTPError myself and verfied the the code actually catches all
HTTPErrors
, on another note this PR also makes the exception catching more specific over catching allExceptions
If the
429 Client Errors
re-appear they should be handled by the current code; otherwise should be addressed differently preferrably in the_send_request
function without redirection ofstdout/stderr
streams.