Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry Pick] Internal dev README (potentially user-facing README) #239

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

dbogunowicz
Copy link
Contributor

@dbogunowicz dbogunowicz commented Oct 6, 2022

Cherry-picking this guy: #205

dbogunowicz and others added 2 commits October 6, 2022 13:15
* initial commit

* merge readmes

* just need grammar and consistency review

* Apply suggestions from code review

* Update README.md

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* Update README.md

Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com>
Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>
* initial commit

* merge readmes

* just need grammar and consistency review

* Apply suggestions from code review

* Update README.md

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* Update README.md

Co-authored-by: bogunowicz@arrival.com <bogunowicz@arrival.com>
Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>
@dbogunowicz dbogunowicz requested review from a team, tdg5, bfineran and rahul-tuli and removed request for a team October 6, 2022 11:16
@rahul-tuli
Copy link
Member

rahul-tuli commented Oct 6, 2022

Could we update the description with the original PR number this commit is from?

@dbogunowicz dbogunowicz changed the title Cherry pick/update main readme [Cherry Pick] Internal dev README (potentially user-facing README) Oct 6, 2022
Copy link
Member

@rahul-tuli rahul-tuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@dbogunowicz dbogunowicz merged commit 69f96a3 into release/1.2 Oct 6, 2022
@dbogunowicz dbogunowicz deleted the cherry_pick/update_main_readme branch October 6, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants