This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Force-disable upstream tracking #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like there was a single failure in 3.11: |
dhuangnm
requested review from
tlrmchlsmth,
mgoin,
bnellnm,
dhuangnm,
andy-neuma,
derekk-nm and
robertgshaw2-redhat
|
Should the default values be True too? VLLM_NO_USAGE_STATS: bool = False |
That section is purely for type-checking (as in, it is never actually executed because it’s protected by the |
robertgshaw2-redhat
approved these changes
Jun 21, 2024
derekk-nm
pushed a commit
that referenced
this pull request
Jun 24, 2024
This PR force-disables upstream tracking by forcing `VLLM_DO_NOT_TRACK` and `VLLM_NO_USAGE_STATS` to be `True` (disable data collection) rather than inspecting the environment variable. An alternative approach could be to update the definition of `is_usage_stats_enabled` (in [`vllm/usage/usage_lib.py:29`](https://github.com/neuralmagic/nm-vllm/blob/main/vllm/usage/usage_lib.py#L29)) to always return `False` and set the `global _USAGE_STATS_ENABLED` to be `False`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR force-disables upstream tracking by forcing
VLLM_DO_NOT_TRACKandVLLM_NO_USAGE_STATSto beTrue(disable data collection) rather than inspecting the environment variable.An alternative approach could be to update the definition of
is_usage_stats_enabled(invllm/usage/usage_lib.py:29) to always returnFalseand set theglobal _USAGE_STATS_ENABLEDto beFalse.